xodtemplate.c malloc question

Andreas Ericsson ae at op5.se
Wed Dec 17 15:54:21 CET 2008


hiren wrote:
> just something I thought was odd, is the following diff valid?
> thanks.
> 

It's a valid diff, but the patch is entirely moot. A pointer to a
pointer is exactly the same size as a pointer to anything else.
As such, this is just code churn that changes exactly nothing.

> 
> --- xdata/xodtemplate.c	2008-11-30 19:22:59.000000000 +0200
> +++ /tmp/xodtemplate.c	2008-12-15 16:45:58.000000000 +0200
> @@ -175,7 +175,7 @@
>  
>  	/* allocate memory for 256 config files (increased dynamically) */
>  	xodtemplate_current_config_file=0;
> -	xodtemplate_config_files=(char **)malloc(256*sizeof(char **));
> +	xodtemplate_config_files=(char *)malloc(256*sizeof(char *));
>  	if(xodtemplate_config_files==NULL)
>  		return ERROR;
>  

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/




More information about the Developers mailing list