Minor issues with notification macros/cgi

Thomas Guyot-Sionnest thomas at zango.com
Fri Jul 4 19:16:48 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I was playing with notifications, and I noted the following two things:

1. $NOTIFICATIONCOMMENT$ description says that $NOTIFICATIONTYPE$ can be
~ 'CUSTOM', however it looks like custom notification are always of type
PROBLEM or RECOVERY depending on the status of host. IMHO it would be
clearer to print CUSTOM instead (and update $NOTIFICATIONTYPE$ description).

2. In notifications.cgi, it shows the notification comment in the
Information collumn for Acknowledgements, but not for Custom
notifications (and possibly not for downtime - I haven't tested yet). It
would make sense to print the comment just like for acknowledgments.

Due to lack of time I can't provide a patch, but I believe it's pretty
trivial to fix...

Thanks,

Thomas

- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIblsA6dZ+Kt5BchYRAuV3AKC9BVEQpG+GnqmlXGmQ8+5oHxjDBACfVVhh
MFmWRvpV+9dDQdOI8s7SJM4=
=gzSE
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08




More information about the Developers mailing list