skiplist insert free?

hiren hir3npatel at gmail.com
Tue Sep 30 09:20:57 CEST 2008


On Tue, 2008-09-30 at 00:27 -0400, Thomas Guyot-Sionnest wrote:
> This looks valid... update is malloc'ed and initialized with NULLs right
> above the diff chunk... It seems like a temporary buffer and is freed at
> all other places.

cool.

> 
> Even better would be placing this check before the malloc as there's no
> need to malloc it there if we're going to return. You can pull my
> *absolutely untested* patch here...

yeah I agree, much better solution. thanks.

> 
> http://solaris.beaubien.net/cgi-bin/gitweb.cgi/nagios.git/
> 
> 
> - --
> Thomas
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFI4aqv6dZ+Kt5BchYRAhoGAKDxN2V1osbD+wRILcws1N7VwZ9DHgCcD0lO
> 0D7k/e/bHpinDn+VqeK5hew=
> =s/BO
> -----END PGP SIGNATURE-----


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/




More information about the Developers mailing list