nagios patches 3 old, 1 new (fix flexible downtime on service hard state change doesn't get triggered/activated)
Michael Friedrich
michael.friedrich at univie.ac.at
Sat Apr 30 14:11:10 CEST 2011
hi,
since there was no further comments on those patches, i did a revision
after moving to svn. because there isn't any official git mirror yet,
i'm using http://git.weiss.in-berlin.de/repositories/nagios.git and
latest HEAD.
please refer to the already written threads for further information on
the patches themselves.
OLD
[PATCH] core: fix race condition on flexible downtime commands when duration not set or zero
=> added changelog entry
0001-fix-race-condition-on-flexible-downtime-commands-whe.patch
[PATCH] sanitize compiler warnings on size_t in common/macros.c
=> left as it is, re-applied against head.
0002-sanitize-compiler-warnings-on-size_t-in-common-macro.patch
[PATCH] move thread safe macro function prototypes with suffix _r and restore old compatible prototypes again
=> verified against latest t-tap tests, updated .gitignore
0003-move-thread-safe-macro-function-prototypes-with-suff.patch
=====
NEW
fix flexible downtime on service hard state change doesn't get triggered/activated
recently, there was a change on flexible downtime triggering,
allowing soft state changes to active a flexible downtime.
this change removed the condition on hard_state_change check,
so it only triggered those from soft state changes but not
the well known older behavior.
the tricky part is, that those 2 vars are not the same on each
state change, so the replacement fix needs a sanitized "near-by"
addin, which this patch introduces.
this bug has been evaluated and debugged in deep, the fix
now runs>2 months on productive systems, allowing us to
trigger flexible downtimes on hard state changes too, next
to the soft state changes being detected.
please check https://dev.icinga.org/issues/1228 for a deeper
analysis on this.
0004-fix-flexible-downtime-on-service-hard-state-change-d.patch
=====
the new patch is one of those i mentioned from my todo list. please consider them for future releases as it will ease the porting-patches-from-icinga-core procedure.
kind regards,
Michael
--
DI (FH) Michael Friedrich
Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria
email: michael.friedrich at univie.ac.at
phone: +43 1 4277 14359
mobile: +43 664 60277 14359
fax: +43 1 4277 14338
web: http://www.univie.ac.at/zid
http://www.aco.net
Icinga Core& IDOUtils Developer
http://www.icinga.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-race-condition-on-flexible-downtime-commands-whe.patch
Type: text/x-diff
Size: 2346 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20110430/53d8f3a2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sanitize-compiler-warnings-on-size_t-in-common-macro.patch
Type: text/x-diff
Size: 3658 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20110430/53d8f3a2/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-move-thread-safe-macro-function-prototypes-with-suff.patch
Type: text/x-diff
Size: 62129 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20110430/53d8f3a2/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-fix-flexible-downtime-on-service-hard-state-change-d.patch
Type: text/x-diff
Size: 2600 bytes
Desc: not available
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20110430/53d8f3a2/attachment-0003.patch>
-------------- next part --------------
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel
More information about the Developers
mailing list