Reduce some code duplication

Jochen Bern Jochen.Bern at LINworks.de
Thu Jan 13 19:21:37 CET 2011


On 01/13/2011 04:52 PM, Stephen Gran wrote:
> On Thu, Jan 13, 2011 at 02:58:01PM +0100, Andreas Ericsson said:
>> I wonder what happens when eu-admins is both a user
>> (from the apache view of things) as well as a contactgroup, but not a
>> contact. That's one of the things that absolutely has to keep working,
>> or a lot of people's setups will break.
> I was planning to use a marker to specify that it is a group, whether %
> like sudo or @ like many other things

1. Both "%" and "@" are legal separators for e-mail addresses, which are
   getting more and more popular as "usernames" for all sorts of web UI
   logins. I doubt they're safe to forcefully overload, even as
   username[0].
2. I don't think that there's *any* printable character which is prima
   facie illegal in Basic Auth usernames. Not even the "," (and "="?)
   that cgi.cfg sets aside as its separator char(s).
3. Suggestion: Make the marker configurable (so that admins can work
   around odd username[0]s already in use), with setting it to '\0' or
   somesuch effectively disabling the new feature (for the rare cases
   where the user base took pride in having really *every* printable
   character covered ;-).

Kind regards,
								J. Bern
-- 
Jochen Bern, Systemingenieur --- LINworks GmbH <http://www.LINworks.de/>
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP = D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C27
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Geschäftsführer Metin Dogan, Oliver Michel

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl




More information about the Developers mailing list