nagios startup script patch

[Michael Friedrich]

Daniel Wittenberg wrote:
>
> Doesn?t this create potential problem if you just do a normal start 
> with errors and not a restart?   i.e. verify -> stop -> update configs 
> -> start -> die ?
>

the start case already includes a config verification and decides upon 
return value either to start the daemon or to throw an error. the patch 
considers to remove the doubled verification, so i think it's fine.

Kind regards,
Michael


> Dan
>
> *From:*SCHAER Frederic [mailto:frederic.schaer at cea.fr]
> *Sent:* Monday, March 07, 2011 10:30 AM
> *To:* nagios-devel at lists.sourceforge.net
> *Subject:* [Nagios-devel] nagios startup script patch
>
> Hi,
>
> Attached is a patch that intends to remove duplicate configuration 
> checks when (re)starting nagios.
>
> Especially, this divides by three nagios restart time for large 
> configurations since the restart sequence is no more ?verify - stop - 
> verify - start + nagios paths check?, but only ?verify - stop - start 
> without checking paths? .
>
> Without patch, and because of circular dependencies checks, my nagios 
> is taking 15 minutes to restart:
>
> # time service nagios restart
>
> Running configuration check...done.
>
> Stopping nagios: ...done.
>
> Starting nagios: done.
>
> real    15m40.751s
>
> user    15m24.449s
>
> sys     0m1.388s
>
> With this simple patch :
>
> # time service nagios restart
>
> Running configuration check...done.
>
> Stopping nagios: ..done.
>
> Starting nagios: done.
>
> real    5m2.680s
>
> user    4m52.048s
>
> sys     0m0.820s
>
> I hope this gets included in the code?
>
> Cheers,
>
> Frederic Schaer
>
>
>
> ------------------------------------------------------------------------------
> What You Don't Know About Data Connectivity CAN Hurt You
> This paper provides an overview of data connectivity, details
> its effect on application quality, and explores various alternative
> solutions. http://p.sf.net/sfu/progress-d2d
>
>
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel


-- 
DI (FH) Michael Friedrich

Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria

email: 	michael.friedrich at univie.ac.at
phone: 	+43 1 4277 14359
fax: 	+43 1 4277 14338
web:	http://www.univie.ac.at/zid
	http://www.aco.net

Icinga Core&  IDOUtils Developer
http://www.icinga.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20110307/2c770a02/attachment.html>
-------------- next part --------------
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel