[patch] Fix invalid DOM in CGI

Andreas Ericsson ae at op5.se
Mon Jan 9 16:32:16 CET 2012


On 01/09/2012 11:24 AM, Sven-Göran Bergh wrote:
> Bump!
> 

Stashed for applying. I'll take care of it later when I've cleared the
table of some other patches that are currently cooking.

Thanks for the reminder though.

> 
> 
>>>    Från: Andreas Ericsson<ae at op5.se>
>>>    Till: Sven-Göran Bergh<svengbergh-nagiosdevel at yahoo.com>; Nagios
>>>   Developers List<nagios-devel at lists.sourceforge.net>
>>>    Kopia:
>>>    Skickat: fredag, 9 december 2011 15:47
>>>    Ämne: Re: [Nagios-devel] [patch] Fix invalid DOM in CGI
>>>
>>>    On 12/09/2011 03:23 PM, Sven-Göran Bergh wrote:
>>>>
>>>>      Attached patch fixes an invalid DOM.
>>>>
>>>>     A table element may not have a form
>>>>     element as a direct child, but the
>>>>     opposite is OK.
>>>>
>>>>     The forms become invalid in some browsers
>>>>     when the CGI:s are AJAX loaded in div
>>>>     element.
>>>>
>>>
>>>    Neat patch, but why not start the table directly after the form?
>>   
>> Because then some input element will end up directly inside the
>> table element, and that is not valid that either.
>>
>>>    That way it would have been obvious that the patch doesn't change
>>>    the layout. Now it's split so I can't say for sure that it
>>>    doesn't without having to look at the code, and I won't have
>>>    time to do that until next week. Care to reroll and resend a
>>>    more easily reviewed patch?
>>   
>> I think the patch is correct as it is, so no :-)
>>
>>>    Thanks.
>>   
>> Thanks
>> /S-G
>>
>>
>> ------------------------------------------------------------------------------
>> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
>> infrastructure or vast IT resources to deliver seamless, secure access to
>> virtual desktops. With this all-in-one solution, easily deploy virtual
>> desktops for less than the cost of PCs and save 60% on VDI infrastructure
>> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
>>
>>
>> _______________________________________________
>> Nagios-devel mailing list
>> Nagios-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nagios-devel


-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox




More information about the Developers mailing list