Fix CSV output in avail.c

Andreas Ericsson ae at op5.se
Mon Jan 9 16:38:51 CET 2012


On 11/28/2011 09:04 PM, Sven-Göran Bergh wrote:
> Hi,
> 
> attached patch fix the CSV output from avail.c
> to comply better with RFC-4180, see
> 
> http://www.ietf.org/rfc/rfc4180.txt.
> 
> Content-type now is Text/csv, so the browser
> presents a view/save dialog.

How is this an improvement over just hitting Ctrl+S once the page
has loaded? Personally, I detest when pages I *know* is plain text
forces me to click something just in order to either view or save,
when saving after it's viewed is so simple anyway.

> Likewise, CRLF is used.
> 

This could be tricky. I know there are parsers out there that handle
the Nagios-style CSV format, and if they break because we suddenly
choose to go strict with the style we use, we shove a broomstick up
our asses for no gain what so ever.

So... Have you verified that this patch doesn't break anything, or
is that supposed to be an exercise for one of the maintainers? If
you haven't done it, it's unlikely to get done at all, and in that
case the CRLF part of the patch will almost certainly have to be
dropped or modified so that line-endings are given as a character
sequence by the user instead.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox




More information about the Developers mailing list