Nagios 4: Registering object relationships in CGIs

[Andreas Ericsson]

On 01/07/2013 05:31 PM, Ton Voon wrote:
> 
> On 7 Jan 2013, at 16:09, Andreas Ericsson wrote:
> 
>> On 01/07/2013 02:57 PM, Ton Voon wrote:
>>> We're looking at the latest Nagios 4 branch and have seen an issue
>>> where the refactoring around object relationships seems to be missing
>>> for the CGIs. The specific problem is that the contactgroups do not
>>> have all the members populated, though I think host groups and other
>>> relationships are affected.
>>>
>>
>> I think this is already fixed in the svn trunk, and git agrees.
>>
>> commit 4abf7d261e4c710277ddab01fd7b0ad77c1abe13
>> Author: Andreas Ericsson <ae at op5.se>
>> Date:   Wed Dec 5 15:29:04 2012 +0000
>>
>>     xod: Make group member parsing work with precached objects
> 
> I've tried with this version and it doesn't work. The cgis use the cached object file, not the precached object file.
> 

The precached and the cached object files are always identical now (as
the same code is used to generate them), as explained in that commit
message, so the distinction between which files the cgi's use is void.

> I'll create a testcase for you, if that helps.

That would be most helpful, yes.

One major reason for the revamp of the config parsing was that cgi's
and core should share as much of the code as possible in order to both
expose and minimize bugs like this. I'd rather revamp it a bit and
avoid introducing more separate code for core and cgi's than take this
patch, to be honest. A test-case would be perfect though. With one of
those I can easily verify that it's fixed.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412