[RFC] Flapping-notifications (mis)feature

[Arno Lehmann]

Hi,

On 3/3/2006 12:08 PM, Andreas Ericsson wrote:
> A couple of our customers have complained about Nagios sending 
> notifications for hosts and services when a host is in scheduled 
> downtime. Since scheduled downtime usually means "we're upgrading it and 
> then testing the upgrade", this usually means each and every service on 
> the machine will be sending a couple of notifications, often along with 
> notifications for the host itself.
> 
> Going through the source, I see this is the intended behaviour
> 
>     $ grep -A 12 'SPECIAL CASE FOR FLAPPING' base/notifications.c
> 
> to see what I mean.

I didn't look at the code as that wouldn't mean much to me...

> I'm wondering about the usability of this. One good 
> solution is to simply remove the "return OK" after the check for enabled 
> flapping-notifications. Another, imo less good, is to move the entire 
> block of code to below the "normal" case.
> 
> I thought I'd better check with people here to see how they feel about 
> not getting flapping notifications for hosts and services in scheduled 
> downtime before submitting a patch.

What you describe sounds like a bug to me.

> I'm also a bit unsure if this 
> belongs in the 3.x beta branch or if it's to be considered a bugfix and 
> thus to be incorporated in the 2.x branch.

Given the above, I'd think this would be worth a patch agains 2.x.

(And, while I'm just writing an answer to you - Thanks a lot for your 
work and support on Nagios.)

Arno


-- 
IT-Service Lehmann                    al at its-lehmann.de
Arno Lehmann                  http://www.its-lehmann.de


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642