BUG: nagios3 not closing filehandles for checkresult spoolfiles

[Andreas Ericsson]

Please don't top-post. It makes it terribly difficult to follow the
conversation.

Christoph Maser wrote:
> For me this prolem vanished with 3.0.1
> 

That's really, really weird. The only change that could possible
have prevented Nagios 3.0.1 from becoming a fork-bomb if nagios-3.0.0
was is this patch. All other changes between those two revisions are
strictly CGI-related.

---%<---%<---%<---
diff --git a/include/objects.h b/include/objects.h
index f82e39f..6916992 100644
--- a/include/objects.h
+++ b/include/objects.h
@@ -51,20 +51,20 @@
 
 /***************** SKIP LISTS ****************/
 
-#define NUM_OBJECT_SKIPLISTS                   13
-
-#define HOST_SKIPLIST                          1
-#define SERVICE_SKIPLIST                       2
-#define COMMAND_SKIPLIST                       3
-#define TIMEPERIOD_SKIPLIST                    4
-#define CONTACT_SKIPLIST                       5
-#define CONTACTGROUP_SKIPLIST                  6
-#define HOSTGROUP_SKIPLIST                     7
-#define SERVICEGROUP_SKIPLIST                  8
-#define HOSTDEPENDENCY_SKIPLIST                9
-#define SERVICEDEPENDENCY_SKIPLIST             10
-#define HOSTESCALATION_SKIPLIST                11
-#define SERVICEESCALATION_SKIPLIST             12
+#define NUM_OBJECT_SKIPLISTS                   12
+
+#define HOST_SKIPLIST                          0
+#define SERVICE_SKIPLIST                       1
+#define COMMAND_SKIPLIST                       2
+#define TIMEPERIOD_SKIPLIST                    3
+#define CONTACT_SKIPLIST                       4
+#define CONTACTGROUP_SKIPLIST                  5
+#define HOSTGROUP_SKIPLIST                     6
+#define SERVICEGROUP_SKIPLIST                  7
+#define HOSTDEPENDENCY_SKIPLIST                8
+#define SERVICEDEPENDENCY_SKIPLIST             9
+#define HOSTESCALATION_SKIPLIST                10
+#define SERVICEESCALATION_SKIPLIST             11
 
 
---%<---%<---%<---

Perhaps there's something really weird in the skiplist code, or
in how the API is being used. I haven't looked closely and won't
have time to very soon either as I just got back from vacation
with all the insane piles of work such things always amass.


> Chris
> Am Sonntag, den 13.04.2008, 22:55 +0200 schrieb Ethan Galstad:
>> Alessandro Ren wrote:
>>>     I have a similiar problems with nagios 3 and 3rc3, could not locate
>>> yet why this happens.
>>>
>>>     []s.
>>>
>>> Christoph Maser wrote:
>>>> Hi list
>>>>
>>>> we are testing nagios3 and since the release of the final version we
>>>> encountered a massive problem. Once a day nagios stops working
>>>> correctly. Log file ist full of:
>>>>
>>>> -----
>>>> [$timesatmp] Warning: The check of service '$SERVICE' on host '$HOST'
>>>> could not be performed due to a fork() error.  The check will be
>>>> rescheduled.
>>>> -----
>>>>
>>>>
>>>> After a restart of nagios everything works fine again. I have checked
>>>> the checkresult-spool-dir and found tons of _old_ files. When the
>>>> problem occurs nagios has open 1024 FHs most of them (> 1000) for
>>>> checkresult files. Of course 1024 is the open files limit for my nagios
>>>> user.
>>>>
>>>> This problem occurs every day and it started exactly with the install of
>>>> 3.0 final. We where running 3.0rc3 before and did not have any problems.
>>>>
>>>> When i look at the process from time to time i do not see a list of FHs
>>>> building up slowly so i assume that there is some "event" which is
>>>> trigging this malfunction.
>>>>
>>>>
>>>> Chris
>>>>
>> Is anyone else encountering this error?  I'm not seeing anything obvious
>> in the diffs that would have caused this problem post 3.0rc3.
>>
>>
>> Ethan Galstad
>> Nagios Developer
>> ___
>> Email: nagios at nagios.org
>> Web:   www.nagios.org
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
>> Don't miss this year's exciting event. There's still time to save $100.
>> Use priority code J8TL2D2.
>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
>> _______________________________________________
>> Nagios-devel mailing list
>> Nagios-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nagios-devel
> 
> 
> financial.com AG
> 
> Munich head office/Hauptsitz München: Maria-Probst-Str. 19 | 80939 München | Germany
> Frankfurt branch office/Niederlassung Frankfurt: Messeturm | Friedrich-Ebert-Anlage 49 | 60327 Frankfurt | Germany
> Management board/Vorstand: Dr. Steffen Boehnert (CEO/Vorsitzender) | Dr. Alexis Eisenhofer | Dr. Yann Samson | Matthias Wiederwach
> Supervisory board/Aufsichtsrat: Dr. Dr. Ernst zur Linden (chairman/Vorsitzender)
> Register court/Handelsregister: Munich – HRB 128 972 | Sales tax ID number/St.Nr.: DE205 370 553
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel


-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel