[PATCH] circular dependency check speedup

[Andreas Ericsson]

On 12/16/2010 06:52 PM, Glenn Herteg wrote:
> On 12/16/2010 03:23 AM, Andreas Ericsson wrote:
>> I'd appreciate if you could send new threads as new messages
>> instead of as replies to current threads. Especially when you're
>> sending patches. If I hadn't been interested in the topic listed
>> in this thread, I'd have missed this patch and it had been dropped
>> on the floor (unless Ton had applied it, in which case I would
>> have reverted parts of it quite promptly).
> 
> Sorry, I had not realized an old thread reference would be
> preserved in the email headers.
> 

Making a mistake once is nothing. Making the same mistake twice is
stupid. As long as you don't do it again, no harm's done.

>> I've done some organoleptic analysis of the patch (looked at it).
>> Analysis included below.
> 
> Your analysis is based on your general experience, but most of it
> doesn't apply to this patch.  A lot of good engineering work went
> into it, with each improvement based on before/after profiling, to
> identify the hot spots and prove the significant performance gains.
> I'll respond in more detail in a few days.
> 

The problem with claiming superior performance without providing the
testcases to prove it is that if they aren't obviously correct, someone
will ask for them, as am I right now. If you're right in that what I
think will be microscopic improvements really provide the bulk of the
gains, then perhaps it's worth the extra maintenance overhead. If I'm
right and they don't, it's not. Either way, the patch needs to be
rearranged so that the individual changes can be tested by themselves,
and so that I can apply something of it. Like I said; Breaking the
ABI between 3.2.3 and 3.2.4 is a huge nono.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d