[PATCH] circular dependency check speedup

[Ton Voon]

Hi Glenn,

On 15 Dec 2010, at 17:38, Glenn Herteg wrote:

> As provided, the attached patch file is suitable for direct
> application to the Nagios 3.2.3 source code.

Thanks for the patch.

Andreas is interested in performance. I'm interested in "correctness".

I'd like you to provide two tests configurations: 1 with a "complex"  
host dependency tree (various branching etc) and confirmation that a  
nagios -v validates this okay; and 1 with a complex host dependency  
tree that contains a circular path in it and confirmation that a  
nagios -v fails it correctly. This should work with the current code,  
and also work with your patches applied.

See http://wiki.nagios.org/index.php/Nagios_Core_Developer_Guidelines#Testing 
  for more information.

You may want to make your test script like t/900-configparsing.t,  
which confirms that nagios -v works as expected. See also 660status- 
downtimes-comments.t which generates a large status.dat file.

I agree with Andreas that object definition changes need to be in a  
major release, but the test cases can be added now, and other minor  
changes.

Ton


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d