Question, and an Update for Command Expansion Patch

[Michael Friedrich]

Jochen Bern wrote:
> On 11/05/2010 04:46 PM, Andreas Ericsson wrote:
>> I'd prefer if you write them against git at git://git.op5.org/nagios.git
>> (which I keep up to date with my tree) and then email patches with
>> git-send-email, Cc'ing me and To'ing this list.
> Unless you want to become betatester for the first attempts at git of
> someone who's still happier (not to mention faster) coding with "vi"
> within a myEclipse workspace, rather than using the developers'
> myEclipse itself, I'd rather stick to "diff" and e-mail ...
>
>> One patch at a time in separate emails with a brief explanation would
>> work too though, but then I'll take them as and when I have time instead
>> of just applying them directly if they make sense.
> 1/3, coming through ...
>
> What:	Make url_encode() encode control characters correctly;
> 	remove corresponding workaround from Command Expansion code
> Why:    check_commands may contain control chars (e.g., passing a
> 	regexp with a<TAB>  into one of the command_line's $ARGn$s),
> 	but url_encode() changed all control chars to (encoded) spaces.
> 	Since Command Expansion receives the check_command to expand
> 	via URL, it did not receive, much less expand, such
> 	check_commands correctly.

works as expected, thanks.

Kind regards,
Michael
>
>
> ------------------------------------------------------------------------------
> The Next 800 Companies to Lead America's Growth: New Video Whitepaper
> David G. Thomson, author of the best-selling book "Blueprint to a
> Billion" shares his insights and actions to help propel your
> business during the next growth cycle. Listen Now!
> http://p.sf.net/sfu/SAP-dev2dev
>
>
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel


-- 
DI (FH) Michael Friedrich

Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria

email: 	michael.friedrich at univie.ac.at
phone: 	+43 1 4277 14359
fax: 	+43 1 4277 14279
web:	http://www.univie.ac.at/zid

Icinga Core&  IDOUtils Developer
http://www.icinga.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-lists.org/archive/developers/attachments/20101110/49f9bb3a/attachment.html>
-------------- next part --------------
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
-------------- next part --------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel