<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Jonathan,<div><br><div><div>On 28 Jan 2010, at 02:28, Kamens, Jonathan wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div lang="EN-US" link="blue" vlink="purple"><div class="Section1"><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0.0001pt; margin-left: 0in; font-size: 11pt; font-family: Calibri, sans-serif; ">See the attached patch, nagios-3.2.0-startup-speed.patch, which optimizes startup time. It requires the patch I sent last month. I've also attached and updated version of that patch which has some bug fixes in it. Enjoy!</div></div></div></span></blockquote><div><br></div>Thanks. I've noticed this too for comments and downtimes.</div><div><br></div><div>I'm wondering if there is a better way of doing this. Rather than each caller having to work out the next comment id value and making sure it is still unique, I think the next_comment_id should be manipulated within xrddefault.c instead. If you call add_new_comment with a comment_id of 0, it uses next_comment_id and ensures it gets incremented.</div><div><br></div><div>I guess on the initial load of retention.dat you have to validate that the next_comment_id is unique, but you shouldn't have to after that.</div><div><br></div><div>Can you extend the tests in t-tap/ to time the performance increase?</div><div><br></div><div>So I'm thinking that the patch needs a bit more work to be applied.</div><div><br></div><div>Ton</div><div><br></div></div></body></html>