<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body text="#000000" bgcolor="#ffffff"> Jochen Bern wrote: <blockquote cite="mid:4CD41BA9.6040000@LINworks.de" type="cite"> <pre wrap="">On 08/31/2010 04:19 PM, Jochen Bern wrote: </pre> <blockquote type="cite"> <pre wrap="">The whitespace detection is still not quite finished because I hit a snag in the existing code, namely, in cgi/cgiutils.c::url_encode() : </pre> </blockquote> <pre wrap=""> In the process of touching up 3.2.3 (CVS HEAD as of today) to include my local patches, I had a look at the references to url_encode(); I don't think that any reference *other* than the Command Expansion will ever feed control characters into it. Thus, I fixed the "is a space" comparison and removed the workaround in CE. Also included in the attached patch: -- corrected typo in "entry" hyperlink (thanks to Alexey Dvoryanchikov, via Icinga / Michael Friedrich) </pre> </blockquote> Just to correct this - I only notified you about that, patch origin is over here: <a class="moz-txt-link-freetext" href="http://tracker.nagios.org/view.php?id=169">http://tracker.nagios.org/view.php?id=169</a> I've tested and applied it in Icinga GIT, so it could run straight up into Nagios HEAD too. <blockquote cite="mid:4CD41BA9.6040000@LINworks.de" type="cite"> <pre wrap="">-- added hyperlinks to the CE of (active) check commands and event handlers into the extinfo.cgi pages of hosts and services ------- While I'm writing: I intend to streamline some more patches so that they can be included into the authoritative source, but need to be activated by explicit request. I'm thinking along the lines of CFLAGS="-DFEATURE_XY" and optionally adding support into configure, pretty much like --with-feature-xy Or is there an established other syntax/format/... to do this? </pre> </blockquote> What kind of patches/enhancements and can they be made optional by a config option instead? Kind regards, Michael <blockquote cite="mid:4CD41BA9.6040000@LINworks.de" type="cite"> <pre wrap=""> Kind regards, J. Bern </pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! <a class="moz-txt-link-freetext" href="http://p.sf.net/sfu/SAP-dev2dev">http://p.sf.net/sfu/SAP-dev2dev</a></pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Nagios-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Nagios-devel@lists.sourceforge.net">Nagios-devel@lists.sourceforge.net</a> <a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/nagios-devel">https://lists.sourceforge.net/lists/listinfo/nagios-devel</a> </pre> </blockquote> <pre class="moz-signature" cols="72">-- DI (FH) Michael Friedrich Vienna University Computer Center Universitaetsstrasse 7 A-1010 Vienna, Austria email: <a class="moz-txt-link-abbreviated" href="mailto:michael.friedrich@univie.ac.at">michael.friedrich@univie.ac.at</a> phone: +43 1 4277 14359 fax: +43 1 4277 14279 web: <a class="moz-txt-link-freetext" href="http://www.univie.ac.at/zid">http://www.univie.ac.at/zid</a> Icinga Core & IDOUtils Developer <a class="moz-txt-link-freetext" href="http://www.icinga.org">http://www.icinga.org</a> </pre> </body> </html>