[Nagios-users] Bug in 3.0.2 with service escalation contact groups

[Andy Shellam]

Hi,

My comments are inline.

Quoting Mathieu Gagné <mgagne at iweb.com>:

> Hi,
>
> Andy Shellam wrote:
>>
>> The lines you sent for the host escalation were actually for the  
>> host itself!  The host escalation's contacts also had a space in  
>> the strtok() functions, which explains why a host escalation  
>> wouldn't register "Andy Shellam" as a contact name, but would  
>> recognise "NetServe Support" as a contact group.
>
> You are right. Sorry for this mistake.

Don't worry, like you said it highlights the differences in the code!   
I'm guessing that whitespace separators were previously allowed but  
has now changed?

>
> This however reinforce my statement regarding the inconsistency I  
> found across the source code. Should the white-space be considered  
> as a field separator or not?
>
> Somebody should verify the entire source and make sure the same  
> behavior applies everywhere.
>
> Also, by removing the white-space separator, will this still work?  
> (note the white-space)
>
> define hostescalation {
>     contact_groups    contactgroup1, contactgroup2
> }

Good point.

 From my amateur experience with C, I know the "," will split the  
string "contactgroup1, contactgroup2" into "contactgroup1" and "  
contactgroup2" (note the space.)

Whether Nagios would then realise that " contactgroup2" and  
"contactgroup2" should be the same thing, I'm not sure.

>
> --
> Mathieu Gagné
>
>



-- 
Andy Shellam
Business Systems Architect

Network Mail
NetServe Support

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Nagios-devel mailing list
Nagios-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel