nagios patches 3 old, 1 new (fix flexible downtime on service hard state change doesn't get triggered/activated)

[Michael Friedrich]

Hi Ton,

Ton Voon wrote:
>> 0001-fix-race-condition-on-flexible-downtime-commands-whe.patch
> I'm going to push this one back to you to create a suitable test case. Use t-tap/test_commands.c and check return code is ERROR.
>
> I'd vary the inputs too to include 0 or blank or nothing

Ok. Will do when I get more time for writing more tests. Putting 
nagios-users on CC in order to allow users experiencing the same 
problems to test this patch.

>> [PATCH] move thread safe macro function prototypes with suffix _r and restore old compatible prototypes again
>>
>> =>   verified against latest t-tap tests, updated .gitignore
>> 0003-move-thread-safe-macro-function-prototypes-with-suff.patch
> I don't know enough around this area, but I know Andreas is keen on re-entrant functions, so I'll defer to him.

Possibly, maybe it also needs some further adaptions. It's not business 
critical, just compatibility critical for addon developers.

>> =====
>>
>> NEW
>>
>> fix flexible downtime on service hard state change doesn't get triggered/activated
>>
>> recently, there was a change on flexible downtime triggering,
>> allowing soft state changes to active a flexible downtime.
>>
>> this change removed the condition on hard_state_change check,
>> so it only triggered those from soft state changes but not
>> the well known older behavior.
>>
>> the tricky part is, that those 2 vars are not the same on each
>> state change, so the replacement fix needs a sanitized "near-by"
>> addin, which this patch introduces.
>>
>> this bug has been evaluated and debugged in deep, the fix
>> now runs>2 months on productive systems, allowing us to
>> trigger flexible downtimes on hard state changes too, next
>> to the soft state changes being detected.
>>
>> please check https://dev.icinga.org/issues/1228 for a deeper
>> analysis on this.
>>
>>
>> 0004-fix-flexible-downtime-on-service-hard-state-change-d.patch
> This one requires a test case too, due to its complexity. See t-tap/test_checks.c which has tests in the handle_async_check_results routine.

Ok, thanks for the hint. In case there are any users in the Nagios world 
happen to have the same problem, I'd love to see some reports after 
having that patch applied against 3.2.3 or similarities.

>
>> please consider them for future releases as it will ease the porting-patches-from-icinga-core procedure.
> To be honest, that's not my problem. You can make an argument that it is better for Nagios users, but an argument to make your life easier for future patches is not going to sway me. If you choose to fork, then you're accepting a certain cost of maintenance.

Of course not your problem, not even Nagios devs ones, just Nagios users 
maybe.

I was only taking the advantage to "give something back from Icinga". 
Take it or leave it. Just saying that if you're interested in further 
contributions, I'd expect some feedback (just like you did, so thanks 
for the reaction).
If you're insisting on further automated test cases, it's fine, but will 
cause those patches to last longer on that list until resolving more 
important issues. Like I mentioned recently, there are some bugs 
affecting both, Icinga and Nagios I am currently working on.

Talking of forks - I really appreciate the Centreon engine fork. Must 
have happened for a reason, remember the execvp patch on this list? I'm 
keen on seeing what they have been doing, and watching out for further 
ideas on their interesting ideas. the initial released code has various 
things already applied 
(http://www.centreon.com/Centreon/centreon-engine-download.html). 
Shinken is already proofing what's possible, let's welcome another 
competitor in the game :)


Kind regards,
Michael

-- 
DI (FH) Michael Friedrich

Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria

email: 	michael.friedrich at univie.ac.at
phone: 	+43 1 4277 14359
mobile: +43 664 60277 14359
fax: 	+43 1 4277 14338
web:	http://www.univie.ac.at/zid
	http://www.aco.net

Icinga Core&  IDOUtils Developer
http://www.icinga.org


------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay